Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: refactor the image with ADD directives #332

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Nov 27, 2024

  • Use ADD directives instead of curl to download utilities that will be installed
  • Download the archives as part of a multi-stage build
  • Utilize the TARGETARCH for multi-arch builds
  • Unify RUN directives to reduce final image layers

Signed-off-by: dirgim [email protected]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3b85000). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #332   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        18           
  Lines           ?       502           
  Branches        ?         0           
========================================
  Hits            ?       502           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirgim dirgim force-pushed the refactor-curl-downloads branch 6 times, most recently from c22021e to 3f208cf Compare November 29, 2024 12:50
* Use ADD directives instead of curl to download
  utilities that will be installed
* Download the archives as part of a multi-stage build
* Unify RUN directives to reduce final image layers

Signed-off-by: dirgim <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@dirgim dirgim force-pushed the refactor-curl-downloads branch from 9b37c87 to 6bd9ded Compare November 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants