Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ujson (if available) and added /pagedjson page #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jbtronics
Copy link

Added support for ujson (if available) and added /pagedjson page which seperates the json files into pages. (default 50 items per page). With the "items" param you can specify how many items should be shown on a single page. With "page" you specify which page number to show.

jbtronics and others added 4 commits August 22, 2016 18:34
…h seperates the json files into pages. (default 50 items per page). With the "items" param you can specify how many items should be shown on a single page. With "page" you specify which page number to show.
@koniu
Copy link
Owner

koniu commented Sep 19, 2016

Hey, sorry for delay and thanks for the patch! I like the functionality (and haven't tried Recolldroid tho it sounds like a great initiative). On principle, I'm happy to merge but the PR has two problems:

  1. the main patch introduces lots of code repetition, there's bound to be a better way
  2. the changes to README.rst are unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants