Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): [KDL6-196] validate newproject inputs #1085

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joancarballo
Copy link
Contributor

@joancarballo joancarballo commented Dec 16, 2024

Motivation and Context

The inputs when creating new project doesn't validate in step 2.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have created tests for my code changes, and the tests are passing.
  • I have executed the pre-commit hooks locally.
  • I have updated the documentation accordingly.
  • The commit message follows our guidelines: https://github.com/konstellation-io/kdl-server/blob/main/CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

It checks everything but the "select" token/password authentication method needs to be adjusted (depends on kwc npm package so it needs a different update or full refactor).

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@joancarballo joancarballo changed the title feat(ui) KDL6-196 UI validate newproject inputs feat (ui) KDL6-196 UI validate newproject inputs Dec 16, 2024
@joancarballo joancarballo changed the title feat (ui) KDL6-196 UI validate newproject inputs feat(ui): [KDL6-196] validate newproject inputs Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants