feat(app): [KDL6-185] improve user tools operator #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci(github): add docker packages on dependabot
* restructure templates directory by moving filebrowser and mlflow templates into dedicated subdirectories * move shared helper templates to common _helpers.tpl * create separate configmap, deployment, service and networkpolicy templates for each component * remove duplicate chart files and templates * add CI configuration files (ci-values.yaml) * update documentation (README.md, NOTES.txt)
…e-project-operator
…com:konstellation-io/kdl-server into feat/KDL-6-186-improve-project-operator
Update KDL to Create UserTools from Configmap Cleanup config struct with unsused en variables Add test
…b.com:konstellation-io/kdl-server into feat/KDL6-185-improve-user-tools-operator
igzmanuelmartinvivaldi
requested review from
alexrodfe,
igzor and
kafkaphoenix
igzjaviergil
changed the title
ialejandro
force-pushed
the
feat/KDL6-185-improve-user-tools-operator
branch
from
189fe6d to
c8279da
Compare
…-improve-user-tools-operator Signed-off-by: Iván Alejandro Marugán <[email protected]>
|
alexrodfe
approved these changes
Dec 24, 2024
| slugUsername := k.getSlugUsername(username) | ||
| resName := fmt.Sprintf("usertools-%s", slugUsername) | ||
| configMapKdlProjectName := k.cfg.ReleaseName + "-server-user-tools-template" |
There was a problem hiding this comment.
If the configmap naming is used in more places, it could be very useful if this chain is returned as in a builder function instead of having it here declared inside a variable: example, getConfigMapKdlProjectName(release name string) string
| - name: filebrowser-database | ||
| mountPath: "/database.db" | ||
| subPath: "database.db" | ||
| # volumeMounts: |
There was a problem hiding this comment.
watchout, commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Instead of loading User Tools CR from confi and environment variables, create from data in a ConfigMap
Standarization of KDL User Tools CR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information