Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ToDynamic is called consistently when converting a Element(s) #266

Closed
wants to merge 2 commits into from
Closed

Ensure ToDynamic is called consistently when converting a Element(s) #266

wants to merge 2 commits into from

Commits on May 31, 2024

  1. Ensure ToDynamic is called when converting a TaxonomyElement 

    * Simplify FromDynamic conversion for TaxonomyElement
* Fix unit test
    @kylejuliandev
    kylejuliandev committed May 31, 2024
    Configuration menu
    Copy the full SHA
    108543f View commit details
    Browse the repository at this point in the history

  2. Add the ToDynamic call for other Element types 

    * Attempted to do RichTextElement but it broke too many tests, so may need further thought
* Make ToDynamic more consistent in the Element types
* Improve unit test coverage
    @kylejuliandev
    kylejuliandev committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fbd38b2 View commit details
    Browse the repository at this point in the history