Add MAPI resolver #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokornyd
force-pushed
the
DEVREL-1172/add-mapi-resolver
branch
from
f3ee9e4
to
7febf1a
Compare
pokornyd
force-pushed
the
DEVREL-1172/add-mapi-resolver
branch
from
7febf1a
to
64fc52e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 94.79% 93.05% -1.74%
==========================================
Files 19 21 +2
Lines 365 360 -5
Branches 68 82 +14
==========================================
- Hits 346 335 -11
- Misses 19 25 +6 ☔ View full report in Codecov by Sentry. |
IvanKiral
requested changes
Aug 20, 2024
tests/transfomers/portable-text-transformer/html-transformer.spec.ts
Outdated
Show resolved
Hide resolved
tests/transfomers/portable-text-transformer/vue-transformer.spec.ts
Outdated
Show resolved
Hide resolved
pokornyd
force-pushed
the
DEVREL-1172/add-mapi-resolver
branch
from
94db595
to
c4d8010
Compare
IvanKiral
requested changes
Aug 21, 2024
| } | ||
| } | ||
|
|
||
| return throwError("Cannot parse a node that is not a root node."); |
There was a problem hiding this comment.
sorry for confusion, I wanted you to use this function only with ternary operators :D Here I would prefer to the normal
throw new Error("Cannot parse a node that is not a root node.")| return [block]; | ||
| } | ||
| const transformImage: TransformElementFunction<FigureElementAttributes> = (node) => { | ||
| const imageTag = node.children[0] as DomHtmlNode<ImgElementAttributes> | undefined; |
There was a problem hiding this comment.
this is still not correct, it would be better to use some kind of typeguard or conditions at least that the tagName really is in the image tag, even though this code will actually behave kind of correctly, it's still kind of feels a workaround :/
pokornyd
force-pushed
the
DEVREL-1172/add-mapi-resolver
branch
from
c4d8010
to
92c30c7
Compare
IvanKiral
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DEVREL-1172
Adds transformation logic from portable text to MAPI valid rich text.
Checklist
How to test
If manual testing is required, what are the steps?