Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var to const or let #1830

Merged
merged 2 commits into from
Oct 9, 2024
Merged

var to const or let #1830

merged 2 commits into from
Oct 9, 2024

Conversation

tbo47
Copy link

@tbo47 tbo47 commented Oct 5, 2024

I used eslint to change var to const or let. There is some var left, it's for when eslint didn't know.

I changed: ` pointerDirection: GetSet<'left' | 'top' | 'right' | 'bottom' | 'up' | 'down', this>;

To fix:

Error: src/shapes/Label.ts(231,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"up"' have no overlap.
Error: src/shapes/Label.ts(263,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"down"' have no overlap.
Error: src/shapes/Label.ts(300,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"up"' have no overlap.
Error: src/shapes/Label.ts(303,16): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"down"' have no overlap.
Error: Process completed with exit code 1.

@lavrton lavrton merged commit 16bd91b into konvajs:master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants