fix(types): missing any placeholder generics for AnyXstateTreeMachine

This cropped up as type errors for machines that had input and actions
koordinates · Mar 5, 2024 · 050e6a0 · 050e6a0
1 parent d24eb9c
commit 050e6a0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/types.ts b/src/types.ts
@@ -121,7 +121,12 @@ export type XstateTreeMachine<
 /**
  * @public
  */
-export type AnyXstateTreeMachine = XstateTreeMachine<AnyStateMachine>;
+export type AnyXstateTreeMachine = XstateTreeMachine<
+  AnyStateMachine,
+  any,
+  any,
+  any[]
+>;
 /**
  * @internal
  */

diff --git a/src/xstateTree.spec.tsx b/src/xstateTree.spec.tsx
@@ -69,6 +69,13 @@ describe("xstate-tree", () => {
     });
 
     const XstateTreeMachine = createXStateTreeMachine(machine, {
+      // Had a type error when adding in actions to this machine which has now been resolved
+      // keeping it for sanity check
+      actions() {
+        return {
+          foo() {},
+        };
+      },
       View: ({ selectors }) => {
         return <p>{selectors.foo}</p>;
       },

diff --git a/xstate-tree.api.md b/xstate-tree.api.md
@@ -46,7 +46,7 @@ export type AnyRoute = {
 };
 
 // @public (undocumented)
-export type AnyXstateTreeMachine = XstateTreeMachine<AnyStateMachine>;
+export type AnyXstateTreeMachine = XstateTreeMachine<AnyStateMachine, any, any, any[]>;
 
 // @public (undocumented)
 export type ArgumentsForRoute<T> = T extends Route<infer TParams, infer TQuery, any, infer TMeta> ? RouteArguments<TParams, TQuery, TMeta> : never;
@@ -400,8 +400,8 @@ export type XstateTreeMachineStateSchemaV2<TMachine extends AnyStateMachine, TSe
 // src/routing/createRoute/createRoute.ts:285:19 - (ae-forgotten-export) The symbol "MergeRouteTypes" needs to be exported by the entry point index.d.ts
 // src/routing/createRoute/createRoute.ts:285:19 - (ae-forgotten-export) The symbol "ResolveZodType" needs to be exported by the entry point index.d.ts
 // src/routing/createRoute/createRoute.ts:322:9 - (ae-forgotten-export) The symbol "RouteRedirect" needs to be exported by the entry point index.d.ts
-// src/types.ts:137:3 - (ae-incompatible-release-tags) The symbol "canHandleEvent" is marked as @public, but its signature references "CanHandleEvent" which is marked as @internal
-// src/types.ts:138:3 - (ae-incompatible-release-tags) The symbol "inState" is marked as @public, but its signature references "MatchesFrom" which is marked as @internal
+// src/types.ts:142:3 - (ae-incompatible-release-tags) The symbol "canHandleEvent" is marked as @public, but its signature references "CanHandleEvent" which is marked as @internal
+// src/types.ts:143:3 - (ae-incompatible-release-tags) The symbol "inState" is marked as @public, but its signature references "MatchesFrom" which is marked as @internal
 
 // (No @packageDocumentation comment for this package)