Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for SDL fullscreen #899

Open
Frenzie opened this issue Apr 22, 2019 · 0 comments
Open

Unit test for SDL fullscreen #899

Frenzie opened this issue Apr 22, 2019 · 0 comments

Comments

@Frenzie
Copy link
Member

Frenzie commented Apr 22, 2019

It was inadvertently broken because running the program with SDL_FULLSCREEN=1 is seldom if ever tested.
Frenzie added a commit to Frenzie/koreader-base that referenced this issue Apr 22, 2019
@Frenzie
[fix] ffi/SDL2: crash with SDL_FULLSCREEN
dc85617 
Only actively used on device ports (Ubuntu Touch, Sailfish), so it was silently broken.

Cf. koreader/koreader#4960 and koreader#899
@Frenzie Frenzie mentioned this issue Apr 22, 2019
Merged
Frenzie added a commit that referenced this issue Apr 22, 2019
@Frenzie
[fix] ffi/SDL2: crash with SDL_FULLSCREEN (#900)
5be7118 
Only actively used on device ports (Ubuntu Touch, Sailfish), so it was silently broken.

Cf. koreader/koreader#4960 and #899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Frenzie