feat: add support for milestone, assignees and requested reviewers #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Schmid <[email protected]>
|
Wow 😲 thanks for this awesome contribution. I'll give a proper review for this in the coming days, but it looks super useful! |
Whether this is the best ordering is subjective, but I prefer a specific ordering like this until I see a better one (perhaps by categories or so).
The inputs expect `true` to enable the copying behavior. It wasn't really clear from the action.yml nor from the readme that these are boolean flags. By specifying the default as `false` this becomes clear. Ultimately, an empty input would still disable the copying behavior, but that's less relevant than the knowledge that this is a boolean flag. This change doesn't affect the usage or implementation.
I'd like to keep the descriptions of the inputs aligned where possible/useful to avoid confusion about what they do.
The current implementation is not aligned with this description. It copies the currently open review requests and does not request reviews from those that already reviewed the original pull request. Let's adjust the name and the description to fit what it does: copy the requested reviewers not the actual reviewers.
We can log the entire response for any of the failed requests. They may contain valuable info.
korthout
reviewed
Nov 5, 2023
There was a problem hiding this comment.
Thanks again @jschmid1 for these wonderful additions! 🙌
Instead of a review where you have to make the adjustments, I've taken the liberty to make the changes on your pull request directly. I hope that's okay with you. 🙇
The biggest change is that I've adjusted copy_reviewers to `copy_requested_reviewers, as this better fits the behavior.
I'll run some quick tests on this now, and then I think it can be merged and released.
korthout
changed the title
|
Thanks for the quick response! Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@korthout This patch intends to add three new config options:
copy_milestoneCopies the milestone from the original PR to all its backport PRs.
copy_requested_reviewersAssigns the same requested reviewers to the backport PRs as were on the original PR.
copy_assigneesAssigns the same individuals to the backport PRs as were assigned to the original PR.
All of these options are disabled by default.
Addresses: #2