Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for milestone, assignees and requested reviewers #394

Merged
merged 7 commits into from
Nov 5, 2023

Commits on Nov 2, 2023

  1. feat: add support for milestone, assignees and reviewers

    Signed-off-by: Joshua Schmid <[email protected]>
    jschmid1 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0283b4d View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. docs: sort inputs lexicographically

    Whether this is the best ordering is subjective, but I prefer a specific
    ordering like this until I see a better one (perhaps by categories or
    so).
    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    364fd87 View commit details
    Browse the repository at this point in the history
  2. docs: specify false as default for new inputs

    The inputs expect `true` to enable the copying behavior. It wasn't
    really clear from the action.yml nor from the readme that these are
    boolean flags. By specifying the default as `false` this becomes clear.
    
    Ultimately, an empty input would still disable the copying behavior, but
    that's less relevant than the knowledge that this is a boolean flag.
    
    This change doesn't affect the usage or implementation.
    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    397d7f2 View commit details
    Browse the repository at this point in the history
  3. docs: align the input wording

    I'd like to keep the descriptions of the inputs aligned where
    possible/useful to avoid confusion about what they do.
    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    fe78391 View commit details
    Browse the repository at this point in the history
  4. fix: copy requested reviewers not reviewers

    The current implementation is not aligned with this description. It
    copies the currently open review requests and does not request reviews
    from those that already reviewed the original pull request. Let's adjust
    the name and the description to fit what it does: copy the requested
    reviewers not the actual reviewers.
    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    45f65af View commit details
    Browse the repository at this point in the history
  5. fix: align error logs

    We can log the entire response for any of the failed requests. They may
    contain valuable info.
    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    51ff34e View commit details
    Browse the repository at this point in the history
  6. style: apply formatting

    korthout committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    185de06 View commit details
    Browse the repository at this point in the history