New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue# 5: Handled display of cancelled matches #22

Open

nitika1111 wants to merge 1 commit into koushikkothagal:master from nitika1111:issue-no-5

nitika1111 commented May 18, 2021

Hi Koushik,

For cancelled matches (having matchWinner==NA in csv file), I've made following changes:

Added new card color corresponding to cancelled matches
Displayed "Match Cancelled" in place of "NA" for Match Winner Team (in both MatchDetailCard and MatchSmallCard)
Displayed "No decision" in place of "NA" for Player of the Match (in MatchDetailCard)

Pls merge or suggest changes.

Thanks


          Fixed Issue# 5: Handled display of cancelled matches by removing NA d…

18afbd4

…isplay and using different card color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet