Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept a configurable leeway for the token validation #131

Merged
merged 2 commits into from
Apr 5, 2024
Merged

accept a configurable leeway for the token validation #131

merged 2 commits into from
Apr 5, 2024

Conversation

kpacha
Copy link
Member

@kpacha kpacha commented Apr 2, 2024

depends on krakend/go-auth0#4

@kpacha kpacha requested a review from taik0 April 2, 2024 17:39
dhontecillas
dhontecillas approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@dhontecillas dhontecillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
just a question: would make sense to check if the Leeway value is empty, and then assign the default value (the leeway = time.Second), and in case ParseDuration returns an error, return nil, err ?

@kpacha kpacha changed the title [WiP] accept a configurable leeway for the token validation accept a configurable leeway for the token validation Apr 4, 2024
@kpacha kpacha merged commit 4329232 into master Apr 5, 2024
3 checks passed
@kpacha kpacha deleted the leeway branch April 5, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhontecillas dhontecillas dhontecillas approved these changes

@taik0 taik0 Awaiting requested review from taik0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpacha @dhontecillas