This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the fixme in
engine.js
by adding support for multiple view folders as introduced in Express 4.10.The solution looks for a matching template in all folders defined by
app.set('views')
. Checks run in serial to ensure consistent behavior, starting with the first folder and ending with the last.Use Cases
One use case for this allows users to set a fallback directory in case a template is missing.
My personal use case is for Postleaf, where users can create their own themes and, if a template is missing, we fall back to a system template in a different location. Postleaf also uses this feature to support rendering admin views and theme views from a single app instance.
Tests
I'm not super familiar with Mocha, but I ran the tests and all 75 are passing. ✅
It may be worth creating a new test for this patch, though. Maybe a maintainer could point me in the right direction?