fix(initChild): setName is applied in popup context (#444)

* fix(setName): for cross domain * fix(setName): condition * chore(refactor): initChild * chore(refactor): initChild
krakenjs · Nov 2, 2023 · b26b8cb · b26b8cb
1 parent 80b94f9
commit b26b8cb
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/parent/parent.js b/src/parent/parent.js
@@ -713,9 +713,18 @@ export function parentComponent<P, X, C>({
     return ZalgoPromise.try(() => {
       currentChildDomain = childDomain;
       childComponent = childExports;
-      currentProxyWin?.setName(childExports?.name);
-      resolveInitPromise();
-      clean.register(() => childExports.close.fireAndForget().catch(noop));
+
+      currentProxyWin
+        ?.isPopup()
+        .then((isPopup) => {
+          if (childExports?.name !== "" && isPopup) {
+            currentProxyWin?.setName(childExports?.name);
+          }
+        })
+        .finally(() => {
+          resolveInitPromise();
+          clean.register(() => childExports.close.fireAndForget().catch(noop));
+        });
     });
   };