Better DOI term snippet, 3.7+ testing docs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures appear to be unrelated to this |
krassowski
reviewed
Nov 1, 2023
README.md
Outdated
Comment on lines
286
to
291
| try: | ||
| print(result.data['esearchresult']['idlist']) | ||
| except KeyError as exc: | ||
| raise ValueError( | ||
| f"Unexpected response data blob {result.data}." | ||
| ) from exc |
There was a problem hiding this comment.
I would skip error handling from the examples in the readme. They are meant to be illustrative, not comprehensive.
There was a problem hiding this comment.
Good point, thanks! Will implement that shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-exceptblock