Warning cleanup #143
Merged
Warning cleanup #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Skallwar
commented
Aug 27, 2023
Skallwar
commented
- misc: Cleanup warnings
- misc: Cleanup crates
- misc: Change resolver for the workspace
Signed-off-by: Esteban Blanc <[email protected]>
Some crates were not used with the same version depending on the module Signed-off-by: Esteban Blanc <[email protected]>
Fixes an warning Signed-off-by: Esteban Blanc <[email protected]>
Skallwar
force-pushed
the
warning_cleanup
branch
from
3b1cda3
to
d4a0717
Compare
n1tram1
approved these changes
Aug 29, 2023
CohenArthur
approved these changes
Aug 29, 2023
Comment on lines
1
to
+2
| [workspace] | ||
| resolver = "2" |
There was a problem hiding this comment.
we should probably switch to Rust edition 2021, which has the resolver 2.0 enabled by default I think
There was a problem hiding this comment.
Every Cargo.toml is Rust 2021 but by default, virtual workspace is using resolver = "1" for some reason. I had a warning before each and cargo recommended this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.