-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for danish language #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Undo the version changes please, and add .idea
to .gitignore
and remove the folder from the PR, it came along for the ride.
Looks like CI is failing, take a look? Since this is a new feature we should increment the non-patch version from 0.11.13 to 0.12.0. Change the number wherever you find it? |
Yes still failing will take look. |
Could it be this change in your PR? |
you're right could be. Reverted it back. Let's give it a try. |
I think this is as simple as |
done |
Rubocop is complaining, run Double check that the specs include Danish. There are some things like |
I forgot to update the specs after solving some issues. Now all the tests pass correctly locally. Should be fine now. Sorry, I missed that. |
No stress, but RuboCop still unhappy (https://github.com/kslazarev/numbers_and_words/actions/runs/9098488656/job/25014903295?pr=197). Try |
yep, let's see if it's fine now |
Release 1.0.0 (October 17, 2024) Features: - Add support for Danish language. \[[kslazarev#197](https://github.com/kslazarev/numbers_and_words/pull/197)\] \([@franta](https://github.com/Franta1205)\) - Upgrade RuboCop to 1.63.5. \[[kslazarev#198](https://github.com/kslazarev/numbers_and_words/pull/198)\] - Drop support for Ruby 2.7. \[[kslazarev#202](https://github.com/kslazarev/numbers_and_words/pull/202)\] - Drop support for Ruby 3.0. \[[kslazarev#202](https://github.com/kslazarev/numbers_and_words/pull/202)\] - Add support for Ruby 3.3. \[[kslazarev#202](https://github.com/kslazarev/numbers_and_words/pull/202)\]
I added Danish support, tested and is currently actively used by Danish-speaking people.