Merge pull request xbmc#24333 from ksooo/video-fix-strm-video-info

[video] Fix no video information available when playing strm files, …
ksooo · Dec 27, 2023 · fa125a3 · fa125a3
2 parents 7a09e7d + 59aa086
commit fa125a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/xbmc/application/Application.cpp b/xbmc/application/Application.cpp
@@ -2394,8 +2394,9 @@ bool CApplication::PlayFile(CFileItem item, const std::string& player, bool bRes
       if (videoInfoTagPath.find("removable://") == 0 || item.IsVideoDb())
         path = videoInfoTagPath;
 
-      if (!item.HasVideoInfoTag())
-        dbs.LoadVideoInfo(path, *item.GetVideoInfoTag());
+      // Note that we need to load the tag from database also if the item already has a tag,
+      // because for example the (full) video info for strm files will be loaded here.
+      dbs.LoadVideoInfo(path, *item.GetVideoInfoTag());
 
       if (item.HasProperty("savedplayerstate"))
       {

diff --git a/xbmc/video/windows/GUIWindowVideoBase.cpp b/xbmc/video/windows/GUIWindowVideoBase.cpp
@@ -1077,8 +1077,10 @@ bool CGUIWindowVideoBase::PlayItem(const std::shared_ptr<CFileItem>& pItem,
     CServiceBroker::GetPlaylistPlayer().Play();
     return true;
   }
-  else if (pItem->IsPlayList())
+  else if (pItem->IsPlayList() && !pItem->IsType(".strm"))
   {
+    // Note: strm files being somehow special playlists need to be handled in OnPlay*Media
+
     // load the playlist the old way
     LoadPlayList(pItem->GetDynPath(), PLAYLIST::TYPE_VIDEO);
     return true;