chore(build): Add a CI workflow to build and push multiubuntu image whenever a change detected #1878

sikehish · 2024-10-17T19:18:08Z

Purpose of PR?:
Add a CI workflow to build and push the multi-architecture Ubuntu-based image for KubeArmor on changes to the main branch.

Fixes #1876

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::

Verified that the CI workflow builds the Docker image successfully using multi-architecture (amd64 and arm64) support.
Confirmed that the Docker image pushes correctly to Docker Hub when the workflow is triggered by push or pull_request on the main branch.

Additional information for reviewer? :
This PR introduces a new CI workflow and is not dependent on any previous PR or design.

Checklist:

Bug fix. Fixes N/A
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
PR Title follows the convention of <type>(<scope>): <subject>
Commit has unit tests
Commit has integration tests

This reverts commit 0129ca1.

.github/workflows/ci-build-and-push.yml

rksharma95 · 2024-10-18T06:40:52Z

.github/workflows/ci-build-and-push.yml

+          password: ${{ secrets.DOCKER_AUTHTOK }}
+
+      - name: Build and push multi-architecture image
+        uses: docker/build-push-action@v6


examples/multiubuntu/build/build.sh can handle build and push as well, no need to setup docker action for it.
build and push

We need multiarch builds, they are not handled in the script.

my bad, in that case keep repo name same that used in the script

examples/multiubuntu/build/build.sh can handle build and push as well, no need to setup docker action for it. build and push

Do I need to make any changes? Do I need to use examples/multiubuntu/build/build.sh? A bit confused here. Would love for some clarity :))

@sikehish no need to use build.sh script, changes with your PR looks good just change image tag kubearmor/ubuntu-w-utils:latest

Hi @rksharma95 . Ive made the change. Let me know if you need me to change anything else :)

rksharma95 · 2024-10-18T06:43:58Z

@sikehish thanks for the PR, just some suggestions, looks good otherwise. also can you test it on your fork first??

…ndition in build stage.

sikehish · 2024-10-18T14:04:54Z

@sikehish thanks for the PR, just some suggestions, looks good otherwise. also can you test it on your fork first??

Thanks for the oppurtunity too :) I've made all the other changes that you had requested for, barring #1878 (comment) . It's working on my fork.

…-utils:latest

rksharma95 · 2024-10-22T08:21:37Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Added examples/multiubuntu/build path in the CI workflow to run end-to-end tests for any changes.

sikehish · 2024-10-22T08:29:55Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Yup. I've added it. Let me know if any other changes need to be made.

rksharma95 · 2024-10-23T11:14:43Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Yup. I've added it. Let me know if any other changes need to be made.

we'll need handling that the locally built image with changes pushed with PR used in testing. at this point it will just pull the image from kubearmor repo.

sikehish · 2024-10-26T17:29:25Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Yup. I've added it. Let me know if any other changes need to be made.

we'll need handling that the locally built image with changes pushed with PR used in testing. at this point it will just pull the image from kubearmor repo.

I didn't quite get you. Do I have make any change in any of the test yml file? What change do I need to make and in which file? Also, how do I handle the case that latest built ubuntu image be used in the tests? Could you elaborate a bit more.
Thank you!

Manik2708 · 2024-12-04T12:14:47Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Yup. I've added it. Let me know if any other changes need to be made.

we'll need handling that the locally built image with changes pushed with PR used in testing. at this point it will just pull the image from kubearmor repo.

I didn't quite get you. Do I have make any change in any of the test yml file? What change do I need to make and in which file? Also, how do I handle the case that latest built ubuntu image be used in the tests? Could you elaborate a bit more. Thank you!

I guess he is trying to say that in e2e tests, it should pick the locally built image rather than pulling from docker hub. Am I right? @rksharma95? To achieve this need to save docker image of multibuntu with latest tag and then this image will be used for tests. See ci-test-controllers.yml for getting the context of using local images for testing!

sikehish · 2024-12-04T12:43:15Z

@sikehish can you please add examples/multiubuntu/build path as well here, to run the e2e tests for any change

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 3 in 8dd10c4

on:

edit: we'll need to handle the case that latest built ubuntu image should be used in the tests

Yup. I've added it. Let me know if any other changes need to be made.

we'll need handling that the locally built image with changes pushed with PR used in testing. at this point it will just pull the image from kubearmor repo.

I didn't quite get you. Do I have make any change in any of the test yml file? What change do I need to make and in which file? Also, how do I handle the case that latest built ubuntu image be used in the tests? Could you elaborate a bit more. Thank you!

I guess he is trying to say that in e2e tests, it should pick the locally built image rather than pulling from docker hub. Am I right? @rksharma95? To achieve this need to save docker image of multibuntu with latest tag and then this image will be used for tests. See ci-test-controllers.yml for getting the context of using local images for testing!

Thanks for clarifying! I'll look into it

…cally for testing Signed-off-by: sikehish <[email protected]>

sikehish · 2024-12-04T15:04:30Z

Hi @rksharma95 @Manik2708
I've made the requested change. Could you let me know if its okay? I'm currently failing a step (Generate KubeArmor artifacts) in the crio runtime

Manik2708 · 2024-12-04T15:17:49Z

.github/workflows/ci-test-ginkgo.yml

+      - name: Build multiubuntu image
+        run: |
+          cd examples/multiubuntu/build
+          docker build -t kubearmor/multiubuntu:latest .


Please change the name to kubearmor/ubuntu-w-utils:latest

Manik2708 · 2024-12-04T15:20:29Z

Hi @rksharma95 @Manik2708 I've made the requested change. COuld you let me know if its okay? I'm currently failing a step (Generate KubeArmor artifacts) in the crio runtime

Can you share the logs or you local github action report or provide the error?

Manik2708 · 2024-12-04T15:24:33Z

.github/workflows/ci-test-ginkgo.yml

@@ -84,6 +91,12 @@ jobs:

      - name: Run KubeArmor
        run: |
+          if [[ ${{ matrix.runtime }} == "containerd" ]]; then


Why another if statement? Is there any problem for putting in the same if statement?

Why another if statement? Is there any problem for putting in the same if statement?

I thought it'd make it a bit more readable(as the kubearmor related images would be in a different block and the multiubuntu docker save block would be prominent enough. I'll make that change right away :)

sikehish · 2024-12-04T19:08:13Z

Hi @rksharma95 @Manik2708 I've made the requested change. COuld you let me know if its okay? I'm currently failing a step (Generate KubeArmor artifacts) in the crio runtime

Can you share the logs or you local github action report or provide the error?

It worked for containerd, but failed for crio.

Signed-off-by: sikehish <[email protected]>

sikehish · 2024-12-04T19:17:20Z

@rksharma95 @Manik2708 I've made those minor fixes. Is there anything else that needs to be changed?

Manik2708 · 2024-12-05T08:24:10Z

Hi @rksharma95 @Manik2708 I've made the requested change. COuld you let me know if its okay? I'm currently failing a step (Generate KubeArmor artifacts) in the crio runtime

Can you share the logs or you local github action report or provide the error?

It worked for containerd, but failed for crio.

Please share the action logs, it's difficult to conclude from the image!

Manik2708 · 2024-12-05T08:29:01Z

Also some more changes are required! The tests which is using multiubuntu image is ksp_test. This test is applying the yaml file in test/k8s_env/ksp/multiubuntu/multiubuntu-deployment.yaml which is using the 0.1 version of image. Either we have to change it permanently to latest or you can write a command in CI to change it to latest and revert it after the test. Not doing this will always pull image from docker hub instead of using the local one. @rksharma95 Please tell which will be the correct way!

Manik2708 · 2024-12-05T08:30:15Z

Also some more changes are required! The tests which is using multiubuntu image is ksp_test. This test is applying the yaml file in test/k8s_env/ksp/multiubuntu/multiubuntu-deployment.yaml which is using the 0.1 version of image. Either we have to change it permanently to latest or you can write a command in CI to change it to latest and revert it after the test. Not doing this will always pull image from docker hub instead of using the local one. @rksharma95 Please tell which will be the correct way!

You might have to change the imagePullPolicy if required!

rksharma95 · 2024-12-05T09:06:18Z

Also some more changes are required! The tests which is using multiubuntu image is ksp_test. This test is applying the yaml file in test/k8s_env/ksp/multiubuntu/multiubuntu-deployment.yaml which is using the 0.1 version of image. Either we have to change it permanently to latest or you can write a command in CI to change it to latest and revert it after the test. Not doing this will always pull image from docker hub instead of using the local one. @rksharma95 Please tell which will be the correct way!

change it to latest in the deployment,
conditionally build the multiubuntu image based on the check if there's any change, use filter to detect it i.e.

KubeArmor/.github/workflows/ci-test-ginkgo.yml

Line 47 in a42103e

- name: Check what paths were updated

and if local image is supposed to be used in the tests use imagePullPolicy: Never in deployment.

sikehish · 2024-12-07T16:15:36Z

@rksharma95 @Manik2708 I'm looking into the issues flagged. Apologize for the delay; a bit caught up with uni work

Manik2708 · 2024-12-17T08:04:31Z

@rksharma95 @Manik2708 I'm looking into the issues flagged. Apologize for the delay; a bit caught up with uni work

Hi! Are you still working on this PR? Asking if you are facing any problem!

sikehish added 4 commits October 17, 2024 23:35

github/workflows: Created ci-build-and-push.yml

0129ca1

Revert "github/workflows: Created ci-build-and-push.yml"

317dd20

This reverts commit 0129ca1.

github/workflows: Created ci-build-and-push.yml

033e318

github/workflows: Testing change in context in ci-build-and-push.yml

99a0838

sikehish mentioned this pull request Oct 17, 2024

add CI workflow to build and push multiubuntu image on change #1876

Open

rksharma95 requested changes Oct 18, 2024

View reviewed changes

sikehish added 2 commits October 18, 2024 19:31

ci-build-and-push-ubuntu.yml: Renamed the workflow and added an if co…

fd5ac14

…ndition in build stage.

ci-build-and-push-ubuntu.yml: Renamed the workflow and added an if co…

8c96ba2

…ndition in build stage.

ci-build-and-push-ubuntu.yml: Changed image tag to kubearmor/ubuntu-w…

33d96c2

…-utils:latest

rksharma95 previously approved these changes Oct 21, 2024

View reviewed changes

rksharma95 requested a review from daemon1024 October 21, 2024 11:35

chore(ci): add multiubuntu build path for e2e tests

649a416

Added examples/multiubuntu/build path in the CI workflow to run end-to-end tests for any changes.

sikehish dismissed rksharma95’s stale review via 649a416 October 22, 2024 08:28

Merge branch 'kubearmor:main' into main

4b4c8a7

sikehish added 2 commits December 4, 2024 20:20

ci-test-gingko.yml: Added functionality to build multiubuntu image lo…

2501d77

…cally for testing Signed-off-by: sikehish <[email protected]>

Merge branch 'main' of https://github.com/sikehish/KubeArmor

cb94259

Manik2708 reviewed Dec 4, 2024

View reviewed changes

ci-test-ginkgo.yml: Made minor refactoring related changes

1b3cdb9

Signed-off-by: sikehish <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(build): Add a CI workflow to build and push multiubuntu image whenever a change detected #1878

chore(build): Add a CI workflow to build and push multiubuntu image whenever a change detected #1878

sikehish commented Oct 17, 2024

rksharma95 Oct 18, 2024

daemon1024 Oct 18, 2024

rksharma95 Oct 18, 2024

sikehish Oct 18, 2024

rksharma95 Oct 21, 2024

sikehish Oct 21, 2024

rksharma95 commented Oct 18, 2024

sikehish commented Oct 18, 2024

rksharma95 commented Oct 22, 2024 •

edited

Loading

sikehish commented Oct 22, 2024

rksharma95 commented Oct 23, 2024

sikehish commented Oct 26, 2024

Manik2708 commented Dec 4, 2024 •

edited

Loading

sikehish commented Dec 4, 2024

sikehish commented Dec 4, 2024 •

edited

Loading

Manik2708 Dec 4, 2024

Manik2708 commented Dec 4, 2024 •

edited

Loading

Manik2708 Dec 4, 2024

sikehish Dec 4, 2024 •

edited

Loading

sikehish commented Dec 4, 2024 •

edited

Loading

sikehish commented Dec 4, 2024

Manik2708 commented Dec 5, 2024

Manik2708 commented Dec 5, 2024

Manik2708 commented Dec 5, 2024

rksharma95 commented Dec 5, 2024

sikehish commented Dec 7, 2024

Manik2708 commented Dec 17, 2024

chore(build): Add a CI workflow to build and push multiubuntu image whenever a change detected #1878

Are you sure you want to change the base?

chore(build): Add a CI workflow to build and push multiubuntu image whenever a change detected #1878

Conversation

sikehish commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rksharma95 commented Oct 18, 2024

sikehish commented Oct 18, 2024

rksharma95 commented Oct 22, 2024 • edited Loading

sikehish commented Oct 22, 2024

rksharma95 commented Oct 23, 2024

sikehish commented Oct 26, 2024

Manik2708 commented Dec 4, 2024 • edited Loading

sikehish commented Dec 4, 2024

sikehish commented Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

Manik2708 commented Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

sikehish Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

sikehish commented Dec 4, 2024 • edited Loading

sikehish commented Dec 4, 2024

Manik2708 commented Dec 5, 2024

Manik2708 commented Dec 5, 2024

Manik2708 commented Dec 5, 2024

rksharma95 commented Dec 5, 2024

sikehish commented Dec 7, 2024

Manik2708 commented Dec 17, 2024

rksharma95 commented Oct 22, 2024 •

edited

Loading

Manik2708 commented Dec 4, 2024 •

edited

Loading

sikehish commented Dec 4, 2024 •

edited

Loading

Manik2708 commented Dec 4, 2024 •

edited

Loading

sikehish Dec 4, 2024 •

edited

Loading

sikehish commented Dec 4, 2024 •

edited

Loading