Add kubeRBACProxy property to support querying in cluster prometheus in openshift #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mittal-ishaan
force-pushed
the
openshift_in_cluster_prom
branch
from
96579c5
to
64a1cfa
Compare
…crape cost-analyzer
|
This looks good to me. Let's merge when the opencost PR is merged. |
mittal-ishaan
force-pushed
the
openshift_in_cluster_prom
branch
from
8da5e63
to
4082b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Add
kubeRBACProxyproperty to setENABLE_KUBE_RBAC_PROXYas true in the env var of the cost-model andcreatePrometheusClusterRoleBindingproperty to create cluster role binding to grant required permissions to the serviceaccount to query in-cluster prometheus for openshift.Does this PR rely on any other PRs?
opencost/opencost#2944
How does this PR impact users? (This is the kind of thing that goes in release notes!)
THis will enable openshift cluster users to configure installing kubecost while using their in-cluster prometheus.
Links to Issues or tickets this PR addresses or fixes
Closes #3690
What risks are associated with merging this PR? What is required to fully test this PR?
NA
How was this PR tested?
tested by installing kubecost using custom built cost-model image having these changes while disabling the bundled prometheus and using the in-cluster prometheus.
Have you made an update to documentation? If so, please provide the corresponding PR.
not yet, will do. Users will have to add
openshift.io/cluster-monitoring: "true"label for their release namespace