add cost model image tag as env var

[mittal-ishaan]

What does this PR change?

Adds cost model image tag as env var in the container

Does this PR rely on any other PRs?

NA

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Kubecost version in diagnostics page will not show cost-model image tag

Links to Issues or tickets this PR addresses or fixes

https://kubecost.atlassian.net/browse/ENG-2359

What risks are associated with merging this PR? What is required to fully test this PR?

NA

How was this PR tested?

Tried all the scenarios that set the cost model image and checked the corresponding helm template.

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

[jessegoodier]

love this!

[cpanixperi]

Hi, We are facing issue on our production deployment. With this error:

Failed to pull image "gcr.io/kubecost1/kubecost-network-costs:v16.5": rpc error: code = NotFound desc = failed to pull and unpack image "gcr.io/kubecost1/kubecost-network-costs:v16.5": failed to resolve reference "gcr.io/kubecost1/kubecost-network-costs:v16.5": gcr.io/kubecost1/kubecost-network-costs:v16.5: not found

Did this change break something ?

[mittal-ishaan]

No, this change should not be affecting network cost, But could you share the helm values you are using and I can check if we missing something

[cpanixperi]

We are using v1.101.2 of the helm chart. From last 24hrs it is failing to fetch the image "gcr.io/kubecost1/kubecost-network-costs:v16.5"

[mittal-ishaan]

the correct image to this image from what I understand is v0.16.5 i.e. the image should be gcr.io/kubecost1/kubecost-network-costs:v0.16.5. Have you overridden any helm values around it that is causing the image to be gcr.io/kubecost1/kubecost-network-costs:v16.5 and not the one I am suggesting?

[cpanixperi]

No , we haven't done any changes to the chart in last 1 and half years. This image gcr.io/kubecost1/kubecost-network-costs getting pulled by the chart internally. We are not mentioning the tag v16.5 any where in our code.

We believe something changed in kubecost side in last 24 hrs which is breaking this deployment in our clusters .

This shows there was some change 20hrs ago.
https://console.cloud.google.com/gcr/images/kubecost1/GLOBAL/kubecost-network-costs?pli=1

[chipzoller]

@cpanixperi, the issue here is not related to this PR. Please open a support request a support.kubecost.com.

[cpanixperi]

Thanks @chipzoller . Looks like the change is reverted now. There should have been some communication before making such breaking changes.

[jessegoodier]

The 1.102 release is immutable.

Agree with Chip, the issue is certainly not related to this PR and I'm not aware of any other issues with gcr.io