Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chores: remove fileshare client from cloud provider #7131

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Chores: remove fileshare client from cloud provider #7131

merged 1 commit into from
Sep 25, 2024

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Chores: remove fileshare client in cloud provider

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@MartinForReal
Copy link
Contributor Author

releated: kubernetes-sigs/azurefile-csi-driver#2117

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@MartinForReal MartinForReal changed the title Chores: remove fileshare client in cloud provider Chores: remove fileshare client from cloud provider Sep 25, 2024
andyzhangx
andyzhangx approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MartinForReal,andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit d1f0b6e into kubernetes-sigs:master Sep 25, 2024
18 checks passed
@MartinForReal MartinForReal deleted the shafan/removefileshareclient branch September 26, 2024 01:26
@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.31

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.30

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.29

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.31":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.30":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	LICENSES/vendor/golang.org/x/oauth2/LICENSE
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.29":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	LICENSES/vendor/golang.org/x/oauth2/LICENSE
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.28":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	go.sum
M	pkg/provider/azure_storage_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/provider/azure_storage_test.go deleted in remove fileshare client in cloud provider and modified in HEAD. Version HEAD of pkg/provider/azure_storage_test.go left in tree.
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.31

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.30

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.31":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.30":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	LICENSES/vendor/golang.org/x/oauth2/LICENSE
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Oct 14, 2024
Closed
Closed
@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.31

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.30

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.31":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: #7131 failed to apply on top of branch "release-1.30":

Applying: remove fileshare client in cloud provider
Using index info to reconstruct a base tree...
M	LICENSES/vendor/golang.org/x/oauth2/LICENSE
M	go.sum
Falling back to patching base and 3-way merge...
Removing pkg/provider/azure_storage_test.go
Removing pkg/provider/azure_storage.go
Removing pkg/provider/azure_file.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 remove fileshare client in cloud provider

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinForReal @k8s-ci-robot @k8s-infra-cherrypick-robot @andyzhangx