-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert manager is only installed if version mismatch or not yet installed #5278
base: main
Are you sure you want to change the base?
cert manager is only installed if version mismatch or not yet installed #5278
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @audrastump! |
Hi @audrastump. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
||
#verify that the installed version is the same as the version parameter and cert-manager is installed | ||
#install the cert-manager if one of these is false | ||
installed_version = local("kubectl get deployment -n cert-manager cert-manager -o=jsonpath='{.spec.template.spec.containers[0].image}' | awk -F':' '{print $2}'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this awk -F
command work the same on Linuxes and macOS? I ask because often there are BSD vs. GNU-type differences in these commands.
Also, could you squash the commits so there's only one?
/ok-to-test (Although nothing can actually test changes to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
==========================================
+ Coverage 52.78% 52.85% +0.07%
==========================================
Files 270 270
Lines 29057 29121 +64
==========================================
+ Hits 15337 15393 +56
- Misses 12928 12935 +7
- Partials 792 793 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@audrastump: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing issue #5267 where Tilt reinstalls cert-manager on every deployment
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5267
Special notes for your reviewer:
TODOs:
Release note: