-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix ServerMetadata Not Applied to Bastion in OpenStackCluster #2179
base: release-0.10
Are you sure you want to change the base?
🐛 Fix ServerMetadata Not Applied to Bastion in OpenStackCluster #2179
Conversation
- Fixed issue where spec.bastion.spec.serverMetadata was not set in bastion. - Updated bastionToInstanceSpec to apply serverMetadata in InstanceSpec.
The committers listed above are authorized under a signed CLA. |
Welcome @namgon-kim! |
Hi @namgon-kim. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mdbooth how did we deal with PRs only for stable releases? The least minimum is to retitle it to mention that. |
/ok-to-test |
The issue is fixed in
So I'm fine fixing it only stable branches. |
/test pull-cluster-api-provider-openstack-test |
Looks like the linter broke in the stable branch :( How did that happen without making the tests fail? |
/test pull-cluster-api-provider-openstack-test |
/retest-required |
@namgon-kim: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I’ve noticed that the tests are failing due to I ran the linter locally and got the following results:
@EmilienM @mdbooth |
What this PR does / why we need it:
Fixes an issue where
spec.bastion.spec.serverMetadata
inOpenStackCluster
was not applied asmetadata
to OpenStack instances. This change ensures that server metadata is set during bastion creation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2177
Special notes for your reviewer:
TODOs:
/hold