-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial OpenAPI spec for webhook provider #4148
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,214 @@ | ||
--- | ||
openapi: "3.0.0" | ||
info: | ||
version: 0.14.0 | ||
title: External DNS Webhook Server | ||
description: >- | ||
Implements the external DNS webhook endpoints. | ||
contact: | ||
url: https://github.com/kubernetes-sigs/external-dns | ||
license: | ||
name: Apache 2.0 | ||
url: https://www.apache.org/licenses/LICENSE-2.0.html | ||
tags: | ||
- name: initialization | ||
description: Endpoints for initial negotiation. | ||
- name: listing | ||
description: Endpoints to get listings of DNS records. | ||
- name: update | ||
description: Endpoints to update DNS records. | ||
servers: | ||
- url: http://localhost:8888 | ||
description: Server url for a k8s deployment. | ||
paths: | ||
/: | ||
get: | ||
summary: >- | ||
Initialisation and negotiates headers and returns domain | ||
filter. | ||
description: | | ||
Initialisation and negotiates headers and returns domain | ||
filter. | ||
operationId: negotiate | ||
tags: [initialization] | ||
responses: | ||
'200': | ||
description: | | ||
The list of domains this DNS provider serves. | ||
content: | ||
application/external.dns.webhook+json;version=1: | ||
schema: | ||
$ref: '#/components/schemas/filters' | ||
example: | ||
filters: | ||
- example.com | ||
'500': | ||
description: | | ||
Failed to provide the list of domains we serve. | ||
|
||
/records: | ||
get: | ||
summary: Returns the current records. | ||
description: | | ||
Get the current records from the DNS provider and return them. | ||
operationId: getRecords | ||
tags: [listing] | ||
responses: | ||
'200': | ||
description: | | ||
Provided the list of DNS records successfully. | ||
content: | ||
application/external.dns.webhook+json;version=1: | ||
schema: | ||
$ref: '#/components/schemas/endpoints' | ||
'500': | ||
description: | | ||
Failed to provide the list of DNS records. | ||
|
||
post: | ||
summary: Applies the changes. | ||
description: | | ||
Set the records in the DNS provider based on those supplied here. | ||
operationId: setRecords | ||
tags: [update] | ||
requestBody: | ||
description: | | ||
This is the list of changes that need to be applied. There are | ||
four lists of endpoints. The `create` and `delete` lists are lists | ||
of records to create and delete respectively. The `updateOld` and | ||
`updateNew` lists are paired. For each entry there's the old version | ||
of the record and a new version of the record. | ||
required: true | ||
content: | ||
application/external.dns.webhook+json;version=1: | ||
schema: | ||
$ref: '#/components/schemas/changes' | ||
responses: | ||
'204': | ||
description: | | ||
Changes were accepted. | ||
'500': | ||
description: | | ||
Changes were not accepted. | ||
|
||
/adjustendpoints: | ||
post: | ||
summary: Executes the AdjustEndpoints method. | ||
description: | | ||
Adjusts the records in the provider based on those supplied here. | ||
operationId: adjustRecords | ||
tags: [update] | ||
requestBody: | ||
description: | | ||
This is the list of changes to be applied. | ||
required: true | ||
content: | ||
application/external.dns.webhook+json;version=1: | ||
schema: | ||
$ref: '#/components/schemas/endpoints' | ||
responses: | ||
'200': | ||
description: | | ||
Adjustments were accepted. | ||
content: | ||
application/external.dns.webhook+json;version=1: | ||
schema: | ||
$ref: '#/components/schemas/endpoints' | ||
'500': | ||
description: | | ||
Adjustments were not accepted. | ||
|
||
components: | ||
schemas: | ||
filters: | ||
description: | | ||
TODO: explain the filters object. | ||
type: object | ||
properties: | ||
filters: | ||
type: array | ||
items: | ||
type: string | ||
example: | ||
filters: | ||
- foo.example.com | ||
|
||
endpoints: | ||
description: | | ||
This is a list of DNS records. | ||
type: array | ||
items: | ||
$ref: '#/components/schemas/endpoint' | ||
|
||
endpoint: | ||
description: | | ||
This is a DNS record. | ||
type: object | ||
properties: | ||
dnsName: | ||
type: string | ||
targets: | ||
$ref: '#/components/schemas/targets' | ||
recordType: | ||
type: string | ||
setIdentifier: | ||
type: string | ||
recordTTL: | ||
type: integer | ||
format: int64 | ||
labels: | ||
type: object | ||
additionalProperties: | ||
type: string | ||
providerSpecific: | ||
type: array | ||
items: | ||
$ref: '#/components/schemas/providerSpecificProperty' | ||
example: | ||
dnsName: foo.example.com | ||
recordType: A | ||
recordTTL: 60 | ||
|
||
targets: | ||
description: | | ||
This is the list of targets that this DNS record points to. | ||
So for an A record it will be a list of IP addresses. | ||
type: array | ||
items: | ||
type: string | ||
example: | ||
- 1.2.3.4 | ||
- 1.2.3.5 | ||
|
||
providerSpecificProperty: | ||
description: | | ||
TODO: explain the provider object. What might this be used for? | ||
Examples? | ||
type: object | ||
properties: | ||
name: | ||
type: string | ||
value: | ||
type: string | ||
example: | ||
name: foo | ||
value: bar | ||
|
||
changes: | ||
description: | | ||
This is the list of changes send by `external-dns` that need to | ||
be applied. There are four lists of endpoints. The `create` | ||
and `delete` lists are lists of records to create and delete | ||
respectively. The `updateOld` and `updateNew` lists are paired. | ||
For each entry there's the old version of the record and a new | ||
version of the record. | ||
type: object | ||
properties: | ||
create: | ||
$ref: '#/components/schemas/endpoints' | ||
updateOld: | ||
$ref: '#/components/schemas/endpoints' | ||
updateNew: | ||
$ref: '#/components/schemas/endpoints' | ||
delete: | ||
$ref: '#/components/schemas/endpoints' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
piping shell from curl seems to be wrong. This seems also a personal website from which we would fetch the script.
I wonder why we can't just do
go run https://github.com/daveshanley/vacuum
orgo install github.com/daveshanley/vacuum@latest
.Right now it would be a blocking issue given the time after seeing too many supply-chain attacks in the wild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on avoiding this.