fix(Azure DNS): external_dns_registry_errors_total metrics counter value

[dongjiang1989]

Description

The Azure provider should increment external_dns_registry_errors_total when changes cannot be submitted(found, updated, deleted, or created).

Fixes #4510

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dongjiang1989]

@mloiseleur PTAL

[mloiseleur]

Thanks for this PR.
Do you think you can add a test to ensure it won't happen again ?

[dongjiang1989]

Thanks for this PR. Do you think you can add a test to ensure it won't happen again ?

Hmmm... It seems difficult to add unittest case.

external-dns/controller/controller.go

Lines 206 to 211 in e6a3571

	records, err := c.Registry.Records(ctx)
	if err != nil {
	registryErrorsTotal.Inc()
	deprecatedRegistryErrors.Inc()
	return err
	}

external-dns/controller/controller.go

Lines 251 to 256 in 939e7b8

	err = c.Registry.ApplyChanges(ctx, plan.Changes)
	if err != nil {
	registryErrorsTotal.Inc()
	deprecatedRegistryErrors.Inc()
	return err
	}

Is there any better suggestion to add unittest case? 🤔️
@mloiseleur just return errror cases. PTAL

[dongjiang1989]

@mloiseleur @szuecs PTAL re-check

[mloiseleur]

/ok-to-test

[dongjiang1989]

Thanks. @mloiseleur @szuecs Please re-check

[mloiseleur]

/lgtm

[dongjiang1989]

@mloiseleur Do you agree to Merge it? Thanks

[mloiseleur]

@dongjiang1989 An other maintainer will do the final review when he has time. Thanks for your understanding.

[dongjiang1989]

cc @agimenoapinity

[dongjiang1989]

@johngmyers @szuecs PTAL, when you hava time.
thanks.

[Raffo]

Are we generally fine with the change of semantic of how we deal the error? Bubbling this back up has obvious consequences. Specifically, do we want a soft error or not?

[dongjiang1989]

Using errors.join makes it easier to see where an error occurred.
WDYT? @mloiseleur @johngmyers @szuecs

[Raffo]

This doesn’t answer my question. This new error handling will definitely change the way metrics are reported, but also the semantics on what happens when we reach an error. I am not so sure this won’t be a surprise for some users, although we can say that erroring “the hard way” is most likely always the right thing.

[dongjiang1989]

This doesn’t answer my question. This new error handling will definitely change the way metrics are reported, but also the semantics on what happens when we reach an error. I am not so sure this won’t be a surprise for some users, although we can say that erroring “the hard way” is most likely always the right thing.

Thanks @Raffo WDYT?
like:

if err := p.deleteRecords(ctx, deleted); err != nil {
    return err
}

if err := p.updateRecords(ctx, updated); err != nil {
    return err
}

return nil

[Raffo]

This is a different change in a different direction. You won't execute updateRecords in case deleteRecords fail and I am not sure this is the intended change. I think we should not proceed with this change as is unless you can provide a clear picture of what the error handling from the provider should be and what the consequences could be for the users of the provider.

[mloiseleur]

/retitle fix(Azure DNS): external_dns_registry_errors_total metrics counter value