fix(aws): check endpoint for nil before using in aws provider

[mat285]

Description

Check endpoints for nil to ensure they are valid before use in AWS provider

Fixes #4176

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mat285 / name: Michael Turner (027c83d, 999c7ae)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mat285. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mat285]

This seems like a larger issue across all providers, thoughts on a fix to have NewEndpointWithTTL return an error if we can't create the endpoint and then handling that in all providers rather than failing with returning nil

[mat285]

@johngmyers @mloiseleur @Raffo @szuecs sorry to bother yall but whenever you have time would love some feedback/review on this fix

[mloiseleur]

@mat285 No PR are reviewed or merged without test.

BTW, as the dns hostname is limited to 63 characters, wdyt of returning a SoftError (and so log it) ?

[mat285]

@mat285 No PR are reviewed or merged without test.

BTW, as the dns hostname is limited to 63 characters, wdyt of returning a SoftError (and so log it) ?

Thanks for the response, added a test to aws records test. This happens when the dns name has chars outside of the normal ones (I ran into it with a record containing a ~) that get encoded into strings longer than 63 chars. I'm good with returning a softerror and logging instead of just doing a nil check everywhere

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[mloiseleur]

/ok-to-test
@mat285 Do you think you can rebase this PR ?