-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] Add global.imagePullSecrets #4667
[helm] Add global.imagePullSecrets #4667
Conversation
Hi @jkroepke. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
635b6bc
to
0ec4ae3
Compare
/assign @stevehipwell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jkroepke. Could you also add an any type for global
to the JSON schema to cover this support of global in this chart.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jkroepke could you also run helm-docs
and add a CHANGELOG entry so I can run the CI.
Sorry, thanks and done! |
e69bca4
to
e77e697
Compare
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR add the possibility to set imagePullSecrets via
global
variable scope.This pattern is used in cert-manager, grafana and prometheus-community as well.
Fixes #ISSUE
Checklist