-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using envFrom to load environment variables #4671
Conversation
This change is in support of loading environment variables from secrets. The Gandi provider requires the use of an environment variable that needs to be presented securely and this facilitates that.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @genebean! |
Hi @genebean. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
See #3803 and all other PRs about this. |
@mloiseleur: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
That ticket does not address how I'm supposed to provide a secret in a gitops workflow. There is no way I am aware of to securely provide a value to |
Description
This change is in support of loading environment variables from secrets. The Gandi provider requires the use of an environment variable that needs to be presented securely and this facilitates that.
Fixes #4670
Checklist