-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): allow to run tpl on ServiceAccount
annotations
#4958
base: master
Are you sure you want to change the base?
feat(chart): allow to run tpl on ServiceAccount
annotations
#4958
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @fcrespofastly! |
Hi @fcrespofastly. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @szuecs @stevehipwell 👋🏻 ! How do you feel about this change? it should be basically noop, can we launch the tests? |
I also updated the CHANGELOG adding an entry under @szuecs @stevehipwell ☝🏻 I think that's correct right? |
/ok-to-test |
ServiceAccount
annotations
/assign @stevehipwell |
Description
The basic use-case is to add dynamic environmental metadata to external-dns KSA so we can take advantage of advanced cloud IAM features such as IRSA or Workload Identity. We already provide the necessary metadata through values so we could DRY those values and render them in values files. For instance:
This change doesn't break any previous behavior.