📖 Fix: broken url in external-plugins.md #4346
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: monteiro-renato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @monteiro-renato. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
| @@ -148,4 +148,4 @@ kubebuilder create api --plugins go/v4,sampleplugin/v1 | |||
| - A [sample external plugin written in Python](https://github.com/rashmigottipati/POC-Phase2-Plugins) | |||
| - A [sample external plugin written in JavaScript](https://github.com/Eileen-Yu/kb-js-plugin) | |||
|
|
|||
| [code-plugin-external]: ./../../../../../pkg/plugin/external/types.go | |||
| [code-plugin-external]: https://github.com/kubernetes-sigs/kubebuilder/blob/book-v4/pkg/plugin/external/types.go | |||
There was a problem hiding this comment.
Could we change to use the right relative paths?
There was a problem hiding this comment.
Hmm, I think the issue here is that we are not pointing to a .md file.
But I can take a look in the mdBook docs to see if it's possible.
Relevant section > https://book.kubebuilder.io/plugins/extending/external-plugins#how-to-write-an-external-plugin