-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] Add Openstack server hostId as k8s node label #2628
base: master
Are you sure you want to change the base?
Conversation
Welcome @chess-knight! |
Hi @chess-knight. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anguslees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold not sure we reach agreement at #2579 already? |
There is almost no activity. I also contacted guys from kubernetes-sigs/cluster-api-provider-openstack#1605 |
Signed-off-by: Roman Hros <[email protected]>
a00ee1d
to
887a47b
Compare
/test pull-cloud-provider-openstack-check |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Adds OpenStack server hostId to the node labels via the AdditionalLabels feature. It also introduces label name
topology.openstack.org/host-id
which can be discussed further.Which issue this PR fixes(if applicable):
fixes #2579
Special notes for reviewers:
Release note: