-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm]: remove k8s annotations after LB is deleted #2752
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @chnyda! |
Hi @chnyda. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cedric <[email protected]>
What this PR does / why we need it:
If a service was previously of type LoadBalancer, then was switched to another type (for instance NodePort) and the service is switched again to LoadBalancer : the LoadBalancer fails to be created because the LoadBalancer cannot be found (based on the ID from the annotations).
Which issue this PR fixes(if applicable):
fixes #2751
Special notes for reviewers:
Release note: