Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ make sure vsphere cloud provider pod restart gracefully only on modify event #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cmd/vsphere-cloud-controller-manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,9 @@ func initializeWatch(_ *appconfig.CompletedConfig, paths []string) (watch *fsnot
case err := <-watch.Errors:
klog.Warningf("watcher receives err: %v\n", err)
case event := <-watch.Events:
if event.Op != fsnotify.Chmod {
klog.Fatalf("restarting pod because received event %v\n", event)
// only restart pod when monitor an update event or replace event on watched file
if event.Op&fsnotify.Write == fsnotify.Write || event.Op&fsnotify.Remove == fsnotify.Remove {
klog.Errorf("restarting pod because received event %v\n", event)
stopCh <- struct{}{}
} else {
klog.V(5).Infof("watcher receives %s on the mounted file %s\n", event.Op.String(), event.Name)
Expand Down