Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: add test workflow for testing ControlPlaneKubeletLocalMode feature gate #3080

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jun 27, 2024

Use feature gate ControlPlaneKubeletLocalMode.

Only add a "latest" test, because this does not get backproted.

Part of:

test infra PR

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool labels Jun 27, 2024
@k8s-ci-robot k8s-ci-robot requested review from carlory and SataQiu June 27, 2024 07:34
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2024
@chrischdi
Copy link
Member Author

/cc @neolit123 @SataQiu @pacoxu @carlory

@k8s-ci-robot k8s-ci-robot requested review from neolit123 and pacoxu June 27, 2024 07:35
@chrischdi
Copy link
Member Author

/hold to not by accident fastly merge this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2024
@chrischdi chrischdi force-pushed the pr-cp-kubelet-local-tests branch from 921a07a to ca843b9 Compare June 28, 2024 12:01
@chrischdi chrischdi force-pushed the pr-cp-kubelet-local-tests branch from ca843b9 to 34029a8 Compare June 28, 2024 12:06
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

/lgtm
/approve
/hold for kubernetes/kubernetes#125780

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2024
@chrischdi chrischdi force-pushed the pr-cp-kubelet-local-tests branch from 0f83df5 to 8f7cbc8 Compare July 1, 2024 16:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

thanks, seems to have the coverage we discussed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2095c16 into kubernetes:main Jul 12, 2024
4 checks passed
@neolit123
Copy link
Member

tests are green 🎉
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-control-plane-kubelet-local-mode-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants