Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify gcp-gce e2e-gci default periodic job #34007

Merged

Conversation

Rajalakshmi-Girish
Copy link
Contributor

Changing ci-kubernetes-e2e-gci-gce master job to match with release branch job at ci-kubernetes-e2e-gce-cos-k8sbeta-default
Ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1734529922763579?thread_ts=1734528191.048989&cid=C2C40FMNF

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider labels Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 19, 2024
@Rajalakshmi-Girish Rajalakshmi-Girish marked this pull request as draft December 19, 2024 08:52
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added area/gubernator Issues or PRs related to code in /gubernator area/testgrid size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2024
@aojea
Copy link
Member

aojea commented Dec 19, 2024

/assign @mauriciopoppe

@Rajalakshmi-Girish Rajalakshmi-Girish marked this pull request as ready for review December 19, 2024 11:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from deads2k December 19, 2024 11:52
@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the ci-kubernetes-e2e-gci-gce branch 2 times, most recently from 71f0a80 to d70e833 Compare December 19, 2024 12:16
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2024
Copy link
Member

@mauriciopoppe mauriciopoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@dims
Copy link
Member

dims commented Dec 21, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8981c68 into kubernetes:master Dec 21, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

Changing ci-kubernetes-e2e-gci-gce master job to match with release branch job at ci-kubernetes-e2e-gce-cos-k8sbeta-default
Ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1734529922763579?thread_ts=1734528191.048989&cid=C2C40FMNF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/gubernator Issues or PRs related to code in /gubernator area/jobs area/provider/gcp Issues or PRs related to gcp provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants