-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify gcp-gce e2e-gci default periodic job #34007
Modify gcp-gce e2e-gci default periodic job #34007
Conversation
a930c91
to
5f237b2
Compare
5f237b2
to
24cea1d
Compare
/assign @mauriciopoppe |
71f0a80
to
d70e833
Compare
d70e833
to
421bcbb
Compare
421bcbb
to
f8c47a9
Compare
f8c47a9
to
f7cc0d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Rajalakshmi-Girish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rajalakshmi-Girish: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changing ci-kubernetes-e2e-gci-gce master job to match with release branch job at ci-kubernetes-e2e-gce-cos-k8sbeta-default
Ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1734529922763579?thread_ts=1734528191.048989&cid=C2C40FMNF
The job name is being changed from
ci-kubernetes-e2e-gci-gce
toci-kubernetes-e2e-gce-cos-master-default
so as to make this useconfig-forker
in future as per the plan hereAddition of
--env=ENABLE_CACHE_MUTATION_DETECTOR=true
helps catch the scenario where anything mutates a shared informer cache as per @dims comment hereRemoving the args
--gcp-node-image=gci
and--gcp-nodes=4
in master branch job will probably cut down the run to single node cluster. Looks like single node would be enough as release branch jobs are not having these args here and are running fine.The timeout value of job and the timeout arg passed to test run are increased as per https://github.com/kubernetes/test-infra/blob/master/releng/test_config.yaml#L332 and https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/generated/generated.yaml#L294