-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the --cluster flag to gcp's e2e jobs #34042
Remove the --cluster flag to gcp's e2e jobs #34042
Conversation
/approve @Rajalakshmi-Girish thanks! same deal as before, please check these jobs to make sure they are still working in a day or so (fresh runs) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Rajalakshmi-Girish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rajalakshmi-Girish: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Yes Jobs seem to work fine after this change. |
The
--cluster
flag that passes name to CI k8s e2e jobs is not required as the prow jobs are on BOSKOSRef: #33927 (comment)
Most of the jobs that run against master branch for gcp are not passing this value in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml. But a few have empty flag
--cluster=
Removing the flag from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/generated/generated.yaml and also from releng's config file test_config.yaml