Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --cluster flag to gcp's e2e jobs #34042

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@Rajalakshmi-Girish Rajalakshmi-Girish commented Dec 26, 2024

The --cluster flag that passes name to CI k8s e2e jobs is not required as the prow jobs are on BOSKOS
Ref: #33927 (comment)

Most of the jobs that run against master branch for gcp are not passing this value in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml. But a few have empty flag --cluster=

Removing the flag from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/generated/generated.yaml and also from releng's config file test_config.yaml

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 26, 2024
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 26, 2024
@Rajalakshmi-Girish Rajalakshmi-Girish changed the title Remove the --cluster flag to k8s e2e release branch jobs Remove the --cluster flag to gcp's k8s e2e release branch jobs Dec 26, 2024
@Rajalakshmi-Girish Rajalakshmi-Girish changed the title Remove the --cluster flag to gcp's k8s e2e release branch jobs Remove the --cluster flag to gcp's e2e jobs Dec 26, 2024
@dims
Copy link
Member

dims commented Dec 26, 2024

/approve
/lgtm

@Rajalakshmi-Girish thanks! same deal as before, please check these jobs to make sure they are still working in a day or so (fresh runs)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 502e049 into kubernetes:master Dec 26, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

The --cluster flag that passes name to CI k8s e2e jobs is not required as the prow jobs are on BOSKOS
Ref: #33927 (comment)

Most of the jobs that run against master branch for gcp are not passing this value in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml. But a few have empty flag --cluster=

Removing the flag from https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/generated/generated.yaml and also from releng's config file test_config.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rajalakshmi-Girish
Copy link
Contributor Author

please check these jobs to make sure they are still working in a day or so (fresh runs)

Yes Jobs seem to work fine after this change.
I looked at fresh runs of some master and release branch periodic jobs from https://testgrid.k8s.io/sig-release-master-informing ; https://testgrid.k8s.io/sig-release-1.32-blocking, etc.
I am yet to confirm on some presubmits that changed. I have a hurdle fetching their urls.
Posted for help here https://kubernetes.slack.com/archives/CCK68P2Q2/p1735235841755249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants