Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cookie banner when the docs site is embedded #255

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

madebyrogal
Copy link
Contributor

@madebyrogal madebyrogal commented Aug 4, 2023

Description

Changes proposed in this pull request:

  • Disable cookie banner when the docs site is embedded (based on query string)

Testing

Check http://localhost:3000/?embedded=true page and see that the cookie banner is hidden.

@madebyrogal madebyrogal requested review from PrasadG193 and a team as code owners August 4, 2023 14:20
@madebyrogal madebyrogal marked this pull request as draft August 4, 2023 14:20
@madebyrogal madebyrogal changed the title DEV Save Embed docs cloud slack Aug 4, 2023
@pkosiec pkosiec added the enhancement New feature or request label Aug 8, 2023
@pkosiec pkosiec changed the title Embed docs cloud slack Disable cookie banner when the docs site is embedded Aug 8, 2023
@pkosiec pkosiec marked this pull request as ready for review August 8, 2023 15:15
@pkosiec pkosiec self-assigned this Aug 8, 2023
@pkosiec pkosiec enabled auto-merge (squash) August 8, 2023 15:40
@pkosiec pkosiec merged commit be6c429 into kubeshop:main Aug 8, 2023
2 checks passed
@madebyrogal madebyrogal deleted the embed_slack_installation branch February 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants