Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh GraphQL types, add missing flux definition #1179

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Refresh GraphQL types, add missing flux definition #1179

merged 2 commits into from
Aug 10, 2023

Conversation

mszostok
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Refresh GraphQL types

Testing

  1. Install botkube
  2. Checkout PR
  3. Install CLI: go build -o /usr/local/bin/botkube ./cmd/cli
  4. Run: botkube migrate --cloud-api-url http://localhost:8080/graphql

Related issue(s)

Fix https://github.com/kubeshop/botkube/actions/runs/5819970908/job/15780045325

@mszostok mszostok added the bug Something isn't working label Aug 10, 2023
@mszostok mszostok added this to the v1.3.0 milestone Aug 10, 2023
@mszostok mszostok requested review from PrasadG193 and a team as code owners August 10, 2023 12:45
@mszostok mszostok requested a review from pkosiec August 10, 2023 12:45
@mszostok mszostok changed the title Refresh GraphQL types Refresh GraphQL types, add missing flux definition Aug 10, 2023
pkosiec
pkosiec approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

helm/botkube/values.yaml Outdated Show resolved Hide resolved
@pkosiec pkosiec enabled auto-merge (squash) August 10, 2023 13:46
@pkosiec pkosiec disabled auto-merge August 10, 2023 13:51
@pkosiec pkosiec merged commit bbfccd4 into kubeshop:main Aug 10, 2023
13 checks passed
@mszostok mszostok deleted the fix-migration branch August 10, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec