feat(testkube): add networkpolicy support #784
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| {{- if .Values.networkPolicy.enabled -}} | ||
| # this policy will be assigned to any pod in the namespace | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-all | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: {} | ||
| policyTypes: | ||
| - Egress | ||
| egress: | ||
| - to: | ||
| - podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: api-server | ||
| app.kubernetes.io/instance: testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: {{ index .Values "testkube-api" "service" "port" }} | ||
| - to: | ||
| - podSelector: | ||
| matchLabels: | ||
| app: testkube-minio-testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: {{ index .Values "testkube-api" "storage" "endpoint_port" }} | ||
| --- | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-operator | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
|
There was a problem hiding this comment. same as above comment for selector |
||
| control-plane: controller-manager | ||
| policyTypes: | ||
| - Ingress | ||
| ingress: | ||
| - ports: | ||
| - protocol: TCP | ||
| port: 9443 | ||
|
There was a problem hiding this comment. Can this also be referenced through a param? |
||
| --- | ||
| # API must accept connections from everything | ||
| # (e.g. kube-proxy, pods in this namespace, external ingress controller) | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-api-server | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: api-server | ||
| app.kubernetes.io/instance: testkube | ||
| policyTypes: | ||
| - Egress | ||
| - Ingress | ||
| egress: | ||
| - to: | ||
| - podSelector: | ||
| matchLabels: | ||
|
There was a problem hiding this comment. same comment for selectors |
||
| app.kubernetes.io/name: nats | ||
| app.kubernetes.io/instance: testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: 4222 | ||
| - to: | ||
|
There was a problem hiding this comment. this might need to be dynamic if mongodb is disabled (customer is bringing own mongo) |
||
| - podSelector: | ||
| matchLabels: | ||
|
There was a problem hiding this comment. same comment for selectors, they should be used through a helper funcion (from the mongodb chart?) |
||
| app.kubernetes.io/name: mongodb | ||
| app.kubernetes.io/instance: testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: {{ .Values.mongodb.service.port }} | ||
| ingress: | ||
| - ports: | ||
| - protocol: TCP | ||
| port: {{ index .Values "testkube-api" "service" "port" }} | ||
| --- | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-minio | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app: testkube-minio-testkube | ||
| policyTypes: | ||
| - Ingress | ||
| ingress: | ||
| - ports: | ||
| - protocol: TCP | ||
| port: {{ index .Values "testkube-api" "storage" "endpoint_port" }} | ||
| --- | ||
| {{- if .Values.mongodb.enabled -}} | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-mongodb | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: mongodb | ||
| app.kubernetes.io/instance: testkube | ||
| policyTypes: | ||
| - Ingress | ||
| ingress: | ||
| - from: | ||
| - podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/instance: testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: {{ .Values.mongodb.service.port }} | ||
| --- | ||
| {{- end -}} | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-nats | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: nats | ||
| app.kubernetes.io/instance: testkube | ||
| policyTypes: | ||
| - Ingress | ||
| ingress: | ||
| - from: | ||
| - podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/instance: testkube | ||
| ports: | ||
| - protocol: TCP | ||
| port: 4222 | ||
| --- | ||
| {{- if index .Values "testkube-dashboard" "enabled" -}} | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: testkube-dashboard | ||
| namespace: testkube | ||
| spec: | ||
| podSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: dashboard | ||
| app.kubernetes.io/instance: testkube | ||
| policyTypes: | ||
| - Ingress | ||
| ingress: | ||
| - ports: | ||
| - protocol: TCP | ||
| port: {{ index .Values "testkube-dashboard" "service" "port" }} | ||
| {{- end -}} | ||
| {{- end -}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1084,3 +1084,6 @@ testkube-operator: | |
| operator: Equal | ||
| value: arm64 | ||
| effect: NoSchedule | ||
|
|
||
| networkPolicy: | ||
| enabled: false | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done similar to how services use a helper method? Example https://github.com/kubeshop/helm-charts/blob/develop/charts/testkube-api/templates/service.yaml#L27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to refactor to your hearts content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you assist? :)