Merge pull request #511 from kubeshop/perf/synchronizer-get-suppressi…

…ons-query perf(synchronizer): prevent suppressions api request if access token is empty
kubeshop · Sep 13, 2023 · 46be190 · 46be190
2 parents d969c76 + 06d09b8
commit 46be190
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/synchronizer/src/utils/synchronizer.ts b/packages/synchronizer/src/utils/synchronizer.ts
@@ -109,10 +109,16 @@ export class Synchronizer extends EventEmitter {
     };
   }
 
-  async getSuppressions(rootPath: string, accessToken?: string): Promise<ApiSuppression[]>;
-  async getSuppressions(repoData: RepoRemoteData, accessToken?: string): Promise<ApiSuppression[]>;
-  async getSuppressions(projectData: ProjectInputData, accessToken?: string): Promise<ApiSuppression[]>;
-  async getSuppressions(rootPathOrRepoDataOrProjectData: string | RepoRemoteData | ProjectInputData, accessToken = '') {
+  async getSuppressions(rootPath: string, accessToken: string): Promise<ApiSuppression[]>;
+  async getSuppressions(repoData: RepoRemoteData, accessToken: string): Promise<ApiSuppression[]>;
+  async getSuppressions(projectData: ProjectInputData, accessToken: string): Promise<ApiSuppression[]>;
+  async getSuppressions(
+    rootPathOrRepoDataOrProjectData: string | RepoRemoteData | ProjectInputData,
+    accessToken: string
+  ) {
+    if (!accessToken || accessToken?.length === 0) {
+      throw new Error('Cannot fetch without access token.');
+    }
     const inputData = await this.getRepoOrProjectData(rootPathOrRepoDataOrProjectData);
     const suppressions = await this.fetchSuppressionsForRepo(inputData as any, accessToken);
     return suppressions;