chore: address remarks

kubeshop · Sep 12, 2023 · 72d3abf · 72d3abf
1 parent acaf5ac
commit 72d3abf
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/packages/components/src/molecules/ValidationOverview/ProblemRenderer.tsx b/packages/components/src/molecules/ValidationOverview/ProblemRenderer.tsx
@@ -31,8 +31,8 @@ const ProblemRenderer: React.FC<IProps> = props => {
     [selectedProblem, node.problem, groupByFilterValue]
   );
 
-  const absent = useMemo(() => node.problem.baselineState === 'absent', [node]);
-  const hasFix = useMemo(() => node.problem.fixes && node.problem.fixes.length > 0, [node]);
+  const absent = node.problem.baselineState === 'absent';
+  const hasFix = node.problem.fixes && node.problem.fixes.length > 0;
 
   const isUnderReview = useMemo(() => {
     return Boolean(
@@ -122,8 +122,12 @@ const ProblemRenderer: React.FC<IProps> = props => {
 
       <ActionsContainer onClick={e => e.stopPropagation()}>
         {onAutofixHandler && hasFix && !absent ? (
-<Tooltip mouseEnterDelay={TOOLTIP_DELAY} title="Autofix">
-            <Icon name="magic-wand" onClick={() => onAutofixHandler(node.problem)} />
+          <Tooltip mouseEnterDelay={TOOLTIP_DELAY} title="Autofix">
+            <Icon
+              style={{color: isSelected ? Colors.blackPure : Colors.blue7}}
+              name="magic-wand"
+              onClick={() => onAutofixHandler(node.problem)}
+            />
           </Tooltip>
         ) : null}
 

diff --git a/packages/components/src/molecules/ValidationOverview/utils.tsx b/packages/components/src/molecules/ValidationOverview/utils.tsx
@@ -5,6 +5,7 @@ import {
   getFileLocation,
   getResourceLocation,
   getRuleForResultV2,
+  isPendingSuppression,
   isSuppressed,
   ValidationResponse,
   ValidationResult,
@@ -119,10 +120,12 @@ export const filterProblems = (
         );
 
         if (filters.showSuppressed && !filters.showUnsuppressed) {
-          filteredValidationResults = filteredValidationResults.filter(p => isSuppressed(p));
+          filteredValidationResults = filteredValidationResults.filter(p => isSuppressed(p) || isPendingSuppression(p));
         }
         if (!filters.showSuppressed && filters.showUnsuppressed) {
-          filteredValidationResults = filteredValidationResults.filter(p => !isSuppressed(p));
+          filteredValidationResults = filteredValidationResults.filter(
+            p => !isSuppressed(p) && !isPendingSuppression(p)
+          );
         }
         if (!filters.showSuppressed && !filters.showUnsuppressed) {
           return [];

diff --git a/packages/validation/src/node.ts b/packages/validation/src/node.ts
@@ -20,7 +20,7 @@ export * from './config/index.node.js';
 export * from './config/read.node.js';
 export * from './validators/open-policy-agent/wasmLoader/RemoteWasmLoader.node.js';
 
-export function createDefaultNodeMonokleValidator() {
+export function createDefaultMonokleValidator() {
   return new MonokleValidator(
     {
       loader: new RemotePluginLoader(requireFromStringCustomPluginLoader),