Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sarif suppressions #467

Merged
merged 5 commits into from
Jul 28, 2023
Merged

feat: add sarif suppressions #467

merged 5 commits into from
Jul 28, 2023

Conversation

WitoDelnat
Copy link
Collaborator

This PR adds in source suppressions through annotations.

You can add an annotation based on the rule identifier or a more human-readable format:

  • monokle.io/suppress.kbp.no-latest-image (monokle.io/suppress.{pluginId}.{ruleName})
  • monokle.io/suppress.KBP001 (monokle.io.suppress.{ruleId})
  • The value for this annotation can be a boolean (true to skip, false to not skip, or a string which will skip and use that string-value as a justification for the suppression).

f1ames
f1ames suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some minor things to address 👍

packages/validation/src/sarif/suppressions/AnnotationSuppressor.ts Outdated Show resolved Hide resolved
packages/validation/src/sarif/suppressions/Suppressor.ts Outdated Show resolved Hide resolved
@WitoDelnat WitoDelnat force-pushed the add-sarif-suppressions branch 2 times, most recently from a3580b4 to 9c14b43 Compare July 28, 2023 10:29
f1ames
f1ames approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WitoDelnat WitoDelnat merged commit 80f938d into main Jul 28, 2023
1 check passed
@WitoDelnat WitoDelnat deleted the add-sarif-suppressions branch July 28, 2023 11:37
@f1ames f1ames mentioned this pull request Jul 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1ames f1ames f1ames approved these changes

@devcatalin devcatalin Awaiting requested review from devcatalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WitoDelnat @f1ames