-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom popup for displaying editor schemas #2049
Draft
olensmar
wants to merge
7
commits into
main
Choose a base branch
from
olelensmar/feat/schemaUri-in-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6720502
feat: initial implementation of local server for hosting editor schemas
olensmar bed1262
fix: housekeeping
olensmar 68ec3eb
fix: added workaround for missing standalone CustomResourceDefinition…
olensmar 8140b8f
fix: refactoring and added support for file-based schemas
olensmar 70eddfe
fix: removed local server and provided scaffolding for opening schema…
olensmar 3cba220
fix: removed get-port dependency
olensmar 67117c4
fix: removed get-port dependency
olensmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import {BrowserWindow} from 'electron'; | ||
|
||
import getPort from 'get-port'; | ||
import * as http from 'http'; | ||
|
||
const isDev = process.env.NODE_ENV === 'development'; | ||
const localContent: Record<string, string> = {}; | ||
let server: http.Server | undefined; | ||
|
||
export const createWorker = () => { | ||
let workerWindow = new BrowserWindow({show: false}); | ||
|
||
if (isDev) { | ||
workerWindow.loadURL('http://localhost:3000/worker.html'); | ||
workerWindow.webContents.openDevTools(); | ||
} else { | ||
workerWindow.loadURL(`file://${__dirname}/../../worker.html`); | ||
} | ||
|
||
workerWindow.webContents.once('did-finish-load', () => { | ||
console.log('Worker initialized..'); | ||
}); | ||
}; | ||
|
||
function initServer() { | ||
console.log('Initializing local server'); | ||
server = http.createServer((req, res) => { | ||
if (req.url && localContent[req.url]) { | ||
console.log(`Serving content for ${req.url}`); | ||
res.write(localContent[req.url]); | ||
res.end(); | ||
} else { | ||
res.end(`Not found - stranger things have happened.`); | ||
} | ||
}); | ||
|
||
if (server) { | ||
getPort({port: 51038}).then(port => { | ||
if (server) { | ||
server.listen(port); | ||
console.log(`Local server listening on port ${port}`); | ||
} | ||
}); | ||
} | ||
} | ||
|
||
export const addLocalServerContent = (path: string, schema: string) => { | ||
if (!server) { | ||
initServer(); | ||
} | ||
|
||
localContent[path] = schema; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<title>Monokle Worker</title> | ||
</head> | ||
<body> | ||
<p>This is only shown in dev mode - to give access to DevTools</p> | ||
<script> | ||
// your background code here | ||
</script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port is hardcoded - need to get the actual port from the server