feat: add the ability to install the agent and control plane without secrets #189
Conversation
…ity-to-install-the-agent-and-control-plane Conflicts: charts/testkube-enterprise/Chart.lock charts/testkube-enterprise/Chart.yaml charts/testkube-enterprise/values.yaml
There was a problem hiding this comment.
do we need this ci folder in our charts?
There was a problem hiding this comment.
Probably not, I just did the helm pull and made my changes on the vendored copy. It was easier not to make too many changes to the original, so that I could easily produce a patch to contribute to the upstream repository.
| @@ -302,6 +307,10 @@ spec: | |||
| value: "{{ $minioSkipVerify }}" | |||
| - name: MINIO_EXPIRATION | |||
| value: "{{ .Values.api.minio.expirationPeriod }}" | |||
| {{- if .Values.api.minio.credsFilePath }} | |||
| - name: MINIO_SHARED_CREDENTIALS_FILE | |||
There was a problem hiding this comment.
was this env var added to the API code? also how to define the creds in this file?
There was a problem hiding this comment.
This is environment variable is accessed by the Minio Go SDK.
I added the ability to specify Minio credentials by file here:
https://github.com/kubeshop/testkube-cloud-api/pull/1371
How to define the credentials in this file is described in the accompanying docs here:
https://github.com/kubeshop/testkube-docs/pull/58/files#diff-afed191427785df27b2a6e0cd7840e9fceab8a15af487b5e62f9b20ea326ba46R237
There was a problem hiding this comment.
do we also need to have templates for cassandra, mariadb etc..?
There was a problem hiding this comment.
Probably not, but I did not prune the chart down to only what we need.
The intent is for us to get the PRs merged into the upstream repos and then maybe go back to using the original charts.
Otherwise, we could look into trimming these charts later.
…ity-to-install-the-agent-and-control-plane Conflicts: charts/testkube-enterprise/Chart.lock charts/testkube-enterprise/values.yaml
ed382
deleted the
tkc-2139-add-the-ability-to-install-the-agent-and-control-plane
branch
I have forked/vendored the Dex and Minio charts to enable installations without secrets. The following PRs have been contributed to the upstream charts:
Checklist: