community, wg, arch: add wg, sig subprojects and charter for S390x and ARM #298
Conversation
kubevirt-bot
added
the
dco-signoff: yes
wg-arch-arm/charter.md
Outdated
|
|
||
| #### Code, Binaries and Services | ||
|
|
||
| - list of what qualifies a piece of code, binary or service |
There was a problem hiding this comment.
@zhlhahaha hey, here's the charter for the wg arch arm, please chime in here with the things you want to have added, I'll happily integrate them
There was a problem hiding this comment.
I'm unsure about what should be included in the "In Scope" section. Perhaps we can follow the same outlines used for x86_64.
Regarding the "Out of Scope" section, I believe we currently only support KVM-based emulation on Arm64 servers. Therefore, binary-based emulation and services on Arm32 are not within the scope.
| mission_statement: | | ||
| WG ARCH ARM takes care of all things related to supporting ARM architecture on KubeVirt clusters. | ||
| This includes all build processes, also support of failing builds or test lanes. | ||
| label: wg-arch-arm |
There was a problem hiding this comment.
@zhlhahaha hey, here's the entry for the wg arch arm, please chime in here with the things you want to have added, I'll happily integrate them
There was a problem hiding this comment.
Do we have a definition of what chairs/lead responsibilities are? I want to know that before agreeing.
There was a problem hiding this comment.
SIGs must have at least one and ideally two SIG chairs at any given time. SIG chairs are intended to be organizers and facilitators, responsible for the operation of the SIG and for communication and coordination with the other SIGs, the Steering Committee, and the broader community.
if we map that to WG chairs then I figure WG chairs are responsible of WG operation and for communication and coordination with stakeholder SIGs.
This is mostly organizational topics, see k8s wg-governance
@aburdenthehand @fabiand @lyarwood WDYT?
There was a problem hiding this comment.
@awels we recently updated the membership policy by adding some roles here: https://github.com/kubevirt/community/blob/main/membership_policy.md#special-interest-group-sig-chair
There was a problem hiding this comment.
If @andymcc agrees I would be okay with being co-chair with him.
| @@ -174,6 +174,35 @@ sigs: | |||
| teams: | |||
| - name: kubevirt-community | |||
| description: General Discussion | |||
| workinggroups: | |||
| - dir: wg-arch-s390x | |||
There was a problem hiding this comment.
@cfilleke @jschintag @vamsikrishna-siddu hey, here's the entry for the wg arch S390x, please chime in here with the things you want to have added, I'll happily integrate them
wg-arch-s390x/charter.md
Outdated
|
|
||
| #### Code, Binaries and Services | ||
|
|
||
| - list of what qualifies a piece of code, binary or service |
There was a problem hiding this comment.
@cfilleke @jschintag @vamsikrishna-siddu hey, here's the charter for the wg arch S390x, please chime in here with the things you want to have added, I'll happily integrate them
There was a problem hiding this comment.
Thanks for getting this party started, @dhiller !
There was a problem hiding this comment.
Hi @dhiller I have put the things I want to add for s390x in my branch here. vamsikrishna-siddu@b7c6af2
can you please review them and add those changes in your PR for s390x.
Thanks
There was a problem hiding this comment.
Thank you @dhiller!
See comments below regarding the templates
wg-TEMPLATE/wg-charter-template.md
Outdated
| explain your work to a colleague who is familiar with KubeVirt but not | ||
| necessarily all of the internals. | ||
|
|
||
| ### In scope |
There was a problem hiding this comment.
I see this one is not explained and not being used below. Can we remove it?
wg-TEMPLATE/wg-charter-template.md
Outdated
| ### Out of scope | ||
|
|
||
| Outline of things that could be confused as falling into this WG but don't or don't right now. |
There was a problem hiding this comment.
WDYT about Goals / Non-Goals instead?
kubevirt-bot
added
the
do-not-merge/hold
dhiller
changed the title
dhiller
changed the title
| @@ -174,6 +201,63 @@ sigs: | |||
| teams: | |||
| - name: kubevirt-community | |||
| description: General Discussion | |||
| subprojects: | |||
| - name: ci-s390x | |||
There was a problem hiding this comment.
@dhiller
A Question fust for my understanding-
Currently it seems these subproject names aren't used in any OWNERS files. So do we need to update/create OWNERS file along side the code files/dirs while we commit the code and hence we don't refer sub-project names anywhere?
There was a problem hiding this comment.
yes, exactly - my intent is to add the subprojects first, and when you add new OWNERS files where you take ownership of code, then the sigs.yaml will be updated with a reference (hopefully by some automation 😄 )
There was a problem hiding this comment.
when you say "the sigs.yaml will be updated with a reference ", do you mean updating the "owners:" section in the subprojects of sigs.yaml?
|
/lgtm |
|
@chandramerla: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dhiller
force-pushed
the
wg-arch
branch
4 times, most recently
from
6712b21
to
d3c8eef
Compare
|
@cfilleke: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dhiller is the hold still relevant? |
Thanks for the reminder :) Yeah, I think a rebase is needed here, other than that it should be good to go. @jean-edouard will ping you again after that's done if you're ok with that? |
Adds parts for s390x architecture: * subprojects in sig-buildsystem and sig-ci * working group * charter document Signed-off-by: Daniel Hiller <[email protected]>
ARM architecture subprojects and working group: * an entry to sigs.yaml that contains details about the ARM WG, * the charter document, which needs to get updated by the wg members, * subprojects for sig-buildsystem and sig-ci with basic OWNERS references Signed-off-by: Daniel Hiller <[email protected]>
|
/unhold @chandramerla @cfilleke @zhlhahaha I have rebased this PR, PTAL, thanks a lot! @jean-edouard FYI |
kubevirt-bot
removed
the
do-not-merge/hold
|
/approve |
kubevirt-bot
requested review from
cfilleke,
chandramerla,
jschintag,
vamsikrishna-siddu and
zhlhahaha
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@cfilleke: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lyarwood since you had been involved for a bit, would you mind taking another look and see whether this is good to go? Thank you! |
What this PR does / why we need it:
PR #301 added the wg-TEMPLATE as a starting point for creating working groups.
This PR adds two initial wg-arch working groups:
to define chairs and leads on S390x and ARM.
Also it defines subprojects in sig-buildsystem and sig-ci, so that arch wg members can own code.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: