tests: Show clearer error message when cleanup tests fail #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error message contained the whole object, but the text was too long and it was truncated, so often we could not read the name and namespace of the objects. Now we show only group, version, kind, namespace and name. Signed-off-by: Andrej Krejcir <[email protected]>
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @0xFelix @codingben |
|
|
There's any chance to also print the status or something that will help to understand why it wasn't deleted? |
codingben
reviewed
Aug 9, 2024
|
|
||
| // Collect resources to more readable names | ||
| objectTypesAndNames := make([]string, 0, len(list.Items)) | ||
| for _, item := range list.Items { |
There was a problem hiding this comment.
Can you move it to a new function that will return readable names?
objectTypesAndNames := getObjectTypesAndNames(list.Items)
Expect(objectTypesAndNames).To(BeEmpty(), "Some resources were not deleted.")
0xFelix
reviewed
Aug 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the error message contained the whole object, but the text was too long and it was truncated, so often we could not read the name and namespace of the objects.
Now we show only group, version, kind, namespace and name.
Release note: