feat: policy timeout protection #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
force-pushed
the
feat-policy-timeout-protection
branch
from
b0a21c9
to
552192f
Compare
3 tasks
jvanz
approved these changes
Dec 22, 2022
Ensure a policy cannot run more than a given amount of time. This is required to fix kubewarden#254 Signed-off-by: Flavio Castelli <[email protected]>
Allow policy-server to be run in daemon mode. This is useful when running our end to end tests. Signed-off-by: Flavio Castelli <[email protected]>
Add e2e tests that: * start policy-server uncontainerized * perform different HTTP request against the server, checking their responses * shut down the policy-server instance Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
feat-policy-timeout-protection
branch
from
b08b008
to
f899ef8
Compare
jvanz
requested changes
Dec 23, 2022
Co-authored-by: José Guilherme Vanz <[email protected]> Signed-off-by: Flavio Castelli <[email protected]>
Ensure the download directory used by the e2e tests exists Signed-off-by: Flavio Castelli <[email protected]>
Ensure the following logs are uploaded when the e2e-tests are ran inside of a GH action: * venom.log * policy-server stdout and stderr Signed-off-by: Flavio Castelli <[email protected]>
Reference published sleep policy, do not load it from local disk Signed-off-by: Flavio Castelli <[email protected]>
Always run the steps that upload the e2e-test logs, even if the main e2e-test failed Signed-off-by: Flavio Castelli <[email protected]>
|
@jvanz I've applied all the changes requested, plus I've managed to fix the e2e-tests 🥳 |
viccuad
reviewed
Jan 5, 2023
viccuad
approved these changes
Jan 5, 2023
jvanz
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure a policy cannot run more than a given amount of time.
This is required to fix #254
Note 1: this PR builds on top of #388 to ensure all the tests are passing
Note 2: this PR depends on kubewarden/policy-evaluator#224