Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS node filter #4374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GDS node filter #4374

wants to merge 1 commit into from

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Oct 16, 2024

Description

This PR adds support to run node predicate in GDS framework. The general workflow is

  • Construct a pipeline populating a semi-mask for nodes passing predicate
  • When writing path, apply this semi-mask against all intermediate nodes (excluding src and dst)

Fixes # (issue)

Contributor agreement

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.41985% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (b3bfc6e) to head (1f3809c).

Files with missing lines Patch % Lines
...include/planner/operator/sip/logical_semi_masker.h 68.75% 5 Missing ⚠️
src/processor/map/map_gds.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4374   +/-   ##
=======================================
  Coverage   88.28%   88.29%           
=======================================
  Files        1355     1355           
  Lines       53650    53716   +66     
  Branches     7109     7117    +8     
=======================================
+ Hits        47367    47427   +60     
- Misses       6108     6115    +7     
+ Partials      175      174    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: dfb9e74d9f098e0607b8d52f2f90a9d0bc67f64c
Branch commit hash: 788ba8c98dd6c7f49337f059ea3ca79c05f0f546

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.00 672.79 -29.78 (-4.43%)
aggregation q28 11716.42 12473.12 -756.71 (-6.07%)
filter q14 127.09 142.50 -15.41 (-10.81%)
filter q15 127.05 151.03 -23.98 (-15.88%)
filter q16 309.70 323.39 -13.69 (-4.23%)
filter q17 451.01 471.42 -20.41 (-4.33%)
filter q18 1974.82 1978.52 -3.70 (-0.19%)
fixed_size_expr_evaluator q07 541.39 558.52 -17.13 (-3.07%)
fixed_size_expr_evaluator q08 762.39 772.87 -10.48 (-1.36%)
fixed_size_expr_evaluator q09 757.81 772.60 -14.79 (-1.91%)
fixed_size_expr_evaluator q10 240.91 256.17 -15.26 (-5.96%)
fixed_size_expr_evaluator q11 232.62 248.63 -16.01 (-6.44%)
fixed_size_expr_evaluator q12 233.78 251.06 -17.28 (-6.88%)
fixed_size_expr_evaluator q13 1478.59 1490.51 -11.92 (-0.80%)
fixed_size_seq_scan q23 116.43 132.66 -16.23 (-12.24%)
join q29 678.48 680.16 -1.68 (-0.25%)
join q30 1452.54 1512.19 -59.65 (-3.94%)
join q31 7.85 11.13 -3.29 (-29.51%)
ldbc_snb_ic q35 369.99 375.91 -5.92 (-1.57%)
ldbc_snb_ic q36 38.26 39.34 -1.08 (-2.76%)
ldbc_snb_is q32 8.76 4.33 4.43 (102.22%)
ldbc_snb_is q33 15.03 12.40 2.63 (21.20%)
ldbc_snb_is q34 2.98 6.43 -3.45 (-53.63%)
multi-rel multi-rel-large-scan 1593.10 1677.97 -84.87 (-5.06%)
multi-rel multi-rel-lookup 75.40 55.91 19.49 (34.85%)
multi-rel multi-rel-small-scan 65.12 67.66 -2.54 (-3.75%)
order_by q25 132.87 150.70 -17.83 (-11.83%)
order_by q26 450.33 486.36 -36.02 (-7.41%)
order_by q27 1453.56 1505.26 -51.70 (-3.43%)
scan_after_filter q01 171.03 186.97 -15.94 (-8.53%)
scan_after_filter q02 163.12 173.57 -10.44 (-6.02%)
shortest_path_ldbc100 q37 4008.97 3435.62 573.36 (16.69%)
shortest_path_ldbc100 q38 78.47 61.73 16.74 (27.12%)
shortest_path_ldbc100 q39 44.62 81.49 -36.86 (-45.24%)
shortest_path_ldbc100 q40 78.85 70.46 8.39 (11.91%)
var_size_expr_evaluator q03 2057.14 2066.06 -8.92 (-0.43%)
var_size_expr_evaluator q04 2319.06 2304.89 14.17 (0.61%)
var_size_expr_evaluator q05 2668.63 2675.54 -6.91 (-0.26%)
var_size_expr_evaluator q06 1346.01 1335.89 10.13 (0.76%)
var_size_seq_scan q19 1462.01 1480.42 -18.41 (-1.24%)
var_size_seq_scan q20 2665.81 2780.02 -114.20 (-4.11%)
var_size_seq_scan q21 2271.86 2279.25 -7.39 (-0.32%)
var_size_seq_scan q22 129.51 132.91 -3.40 (-2.56%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant